Re: s6: compatibility with make<3.82

From: Buck Evan <buck_at_yelp.com>
Date: Wed, 29 Jul 2015 13:07:48 -0700

Thanks for the reply

On Tue, Jul 21, 2015 at 2:39 PM, Laurent Bercot <ska-supervision_at_skarnet.org
> wrote:

> On 21/07/2015 18:36, Buck Evan wrote:
>
>> Apparently the 'private' keyword was added in 3.82, but many of the
>> platforms I care about have older versions of make.
>>
>> Would you accept a patch to factor it out?
>>
>
> Short answer: probably not. Don't waste time on it. (But if you have
> one already, send it anyway - I promise I'll look at it, without
> promising I'll merge it.)
>


> If you have a magical one-liner patch that will solve everything with
> rainbows and butterflies and that I don't have to spend more than two
> minutes on to be convinced it does the right thing, then please send it.
>

No patch with rainbows here. I simply removed the 'private' keywords.
I'm sure it could breaks something subtly, but I don't see how.
It's likely that I don't understand that feature well enough.
Received on Wed Jul 29 2015 - 20:07:48 UTC